From 257f2eb34ca4ac004655f8de09efe61e4f03d3d0 Mon Sep 17 00:00:00 2001 From: ebbit1q Date: Thu, 5 Sep 2019 15:43:51 +0200 Subject: [PATCH] warning message is way too scary (#3805) People keep complaining they can't compile on ubuntu 16.04 because of this warning message, while it just disables 2 "prettyness" warnings and only in the automatically generated code by protobuf which should never be a problem anyway! original pr: #3432 --- common/pb/CMakeLists.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/pb/CMakeLists.txt b/common/pb/CMakeLists.txt index 4f3bdedf..5467303f 100644 --- a/common/pb/CMakeLists.txt +++ b/common/pb/CMakeLists.txt @@ -176,6 +176,7 @@ if(${Protobuf_VERSION} VERSION_LESS "3.1.0") # remove unused parameter and misleading indentation warnings when compiling to avoid errors set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -Wno-unused-parameter -Wno-misleading-indentation") - message(WARNING "Outdated protobuf version found (${Protobuf_VERSION} < 3.1.0), " - "disabled warnings to avoid compilation errors.") + message(WARNING "Older protobuf version found (${Protobuf_VERSION} < 3.1.0), " + "disabled the warnings 'unused-parameter' and 'misleading-indentation' for protobuf generated code " + "to avoid compilation errors.") endif()