From b462f95343edad2fe41a58971044b949aef51ec8 Mon Sep 17 00:00:00 2001 From: Fabio Bas Date: Wed, 24 Feb 2016 23:47:35 +0100 Subject: [PATCH] Warning/ban notifications: null check userInfo pointer before dereferencing it --- common/server.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common/server.cpp b/common/server.cpp index 2540ea52..687f3d4c 100644 --- a/common/server.cpp +++ b/common/server.cpp @@ -268,7 +268,12 @@ QList Server::getOnlineModeratorList() QList results; for (int i = 0; i < clients.size(); ++i) { ServerInfo_User *data = clients[i]->getUserInfo(); - if (data->user_level() & ServerInfo_User::IsModerator || data->user_level() & ServerInfo_User::IsAdmin) //TODO: this line should be updated in the event there is any type of new user level created + + //TODO: this line should be updated in the event there is any type of new user level created + if (data && + (data->user_level() & ServerInfo_User::IsModerator || + data->user_level() & ServerInfo_User::IsAdmin) + ) results << QString::fromStdString(data->name()).simplified(); } return results;