Simplified code

This commit is contained in:
Fabio Bas 2015-04-16 22:20:40 +02:00
parent 9296e6007f
commit c27735b09e

View file

@ -131,18 +131,18 @@ bool FilterItemList::testTypeAndNot(const CardInfo *info, CardFilter::Attr attr)
bool FilterItemList::testTypeOr(const CardInfo *info, CardFilter::Attr attr) const bool FilterItemList::testTypeOr(const CardInfo *info, CardFilter::Attr attr) const
{ {
QList<FilterItem *>::const_iterator i; QList<FilterItem *>::const_iterator i;
bool enabledChilds = false; bool noChildEnabledChild = true;
for (i = childNodes.constBegin(); i != childNodes.constEnd(); i++) { for (i = childNodes.constBegin(); i != childNodes.constEnd(); i++) {
if (!(*i)->isEnabled()) if (!(*i)->isEnabled())
continue; continue;
if(!enabledChilds) if(noChildEnabledChild)
enabledChilds=true; noChildEnabledChild=false;
if ((*i)->acceptCardAttr(info, attr)) if ((*i)->acceptCardAttr(info, attr))
return true; return true;
} }
return enabledChilds ? false : true; return noChildEnabledChild;
} }
bool FilterItemList::testTypeOrNot(const CardInfo *info, CardFilter::Attr attr) const bool FilterItemList::testTypeOrNot(const CardInfo *info, CardFilter::Attr attr) const