aly/servatrice
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Show hours and minutes between 60 and 90 minutes

Browse source
This commit is contained in:
Mitchell Rosen 2014-11-17 20:38:52 -08:00
parent da145bdd7b
commit d0969c10c6
1 changed files with 34 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
cockatrice/src/gamesmodel.cpp
View file

@ -6,39 +6,61 @@
#include <time.h> #include <time.h>
namespace { namespace {
const unsigned SECS_PER_HALF_MIN = 30;
const unsigned SECS_PER_MIN = 60; const unsigned SECS_PER_MIN = 60;
const unsigned SECS_PER_HALF_HOUR = 1600; // 60 * 30 const unsigned SECS_PER_HALF_HOUR = 60 * 30;
const unsigned SECS_PER_HOUR = 3600; // 60 * 60 const unsigned SECS_PER_HOUR = 60 * 60;
const unsigned SECS_PER_90_MINS = 60 * 90;
/** /**
* Pretty print an integer number of seconds ago. Accurate to only one unit, * Pretty print an integer number of seconds ago. Accurate to only one unit,
* rounded. * rounded. As a special case, time between 60 and 90 minutes will display
* both the hours and minutes.
* *
* For example... * For example...
* 0-59 seconds will return "X seconds ago" * 0-59 seconds will return "Xs ago"
* 1-59 minutes will return "X minutes ago"; 90 seconds will return "2 minutes ago" * 1-59 minutes will return "Xm ago"; 90 seconds will return "2m ago"
* 1-23 hours will return "X hours ago"; 90 minutes will return "2 hours ago" * 60-90 minutes will return "Xhr Ym ago"
* 24+ hours will return "1+ days ago", because it seems unlikely that we care about * 91-300 minutes will return "Xhr ago"; 91 minutes will return "2hr ago"
* an accurate timestamp of day old games. * 300+ minutes will return "5+ hr ago", because it seems unlikely that we
* care about an accurate timestamp of old games.
*/ */
QString prettyPrintSecsAgo(uint32_t secs) { QString prettyPrintSecsAgo(uint32_t secs) {
if (secs < SECS_PER_MIN) { if (secs < SECS_PER_MIN) {
//: This will have a number prepended, like "10s ago"
return QString::number(secs).append(QObject::tr("s ago")); return QString::number(secs).append(QObject::tr("s ago"));
} }
if (secs < SECS_PER_HOUR) { if (secs < SECS_PER_HOUR) {
uint32_t mins = secs / SECS_PER_MIN; uint32_t mins = secs / SECS_PER_MIN;
if (secs % SECS_PER_MIN >= SECS_PER_HALF_MIN) if (secs % SECS_PER_MIN >= 30)
mins++; mins++;
//: This will have a number prepended, like "10m ago"
return QString::number(mins).append(QObject::tr("m ago")); return QString::number(mins).append(QObject::tr("m ago"));
} }
// Here, we want to display both the hours and minutes.
//
// There are two small "corner" cases which could be rectified with
// some more knotty iffy-elsey code:
// Between 1:00:00 and 1:00:29 will display "1hr 0m ago"
// Between 1:29:30 and 1:29:59 will display "1hr 31m ago"
//
// Personally, I prefer to keep the code cleaner, and allow these.
if (secs < SECS_PER_90_MINS) {
uint32_t mins = secs / SECS_PER_MIN - 60;
if (secs % SECS_PER_MIN >= 30)
mins++;
return QObject::tr("1hr ")
.append(QString::number(mins))
//: This will have a number prepended, like "5m ago"
.append(QObject::tr("m ago"));
}
if (secs < SECS_PER_HOUR * 5) { if (secs < SECS_PER_HOUR * 5) {
uint32_t hours = secs / SECS_PER_HOUR; uint32_t hours = secs / SECS_PER_HOUR;
if (secs % SECS_PER_HOUR >= SECS_PER_HALF_HOUR) if (secs % SECS_PER_HOUR >= SECS_PER_HALF_HOUR)
hours++; hours++;
//: This will have a number prepended, like "2h ago"
return QString::number(hours).append(QObject::tr("hr ago")); return QString::number(hours).append(QObject::tr("hr ago"));
} }
return QObject::tr("5+ hours ago"); return QObject::tr("5+ hrs ago");
} }
} }