Add lock around deleting arrows for commanding cards Add support for Qt6 w/ Backwards Qt5 Handle Qt5/6 cross compilation better Last cleanups caps matter Fix serv Prevent crash on 6.3.0 Linux & bump to 5.8 min Prevent out of bounds indexing Delete shutdown timer if it exists Fixup ticket comments, remove unneeded guards Try to add support for missing OSes Update .ci/release_template.md Update PR based on comments Update XML name after done and remove Hirsute Address local game crash Address comments from PR (again) Tests don't work on mac, will see if a problem on other OSes make soundengine more consistent across qt versions disable tests on distros that are covered by others Fix Oracle Crash due to bad memory access Update Oracle to use new Qt6 way of adding translations Add support for Qt5/Qt6 compiling of Cockatrice Remove unneeded calls to QtMath/cmath/math.h Update how we handle bitwise comparisons for enums with Tray Icon Change header guards to not duplicate function Leave comment & Fix Path for GHA Qt Update common/server.h Update cockatrice/src/window_main.cpp Rollback change on cmake module path for NSIS check docker image requirements add size limit to ccache put variables in quotes properly set build type on mac avoid names used in cmake fix up cmake module path cmake 3.10 does not recognize prepend Support Tests in FindQtRuntime set ccache size on non debug builds as well immediately return when removing non existing client handle incTxBytes with a signal instead don't set common link libraries in cockatrice/CMakeLists.txt add comments set macos qt version to 6 Try upgrading XCode versions to latest they can be supported on Ensure Qt gets linked add tmate so i can see what's going on Qt6 points two directories further down than Qt5 with regard to the top lib path, so we need to account for this Establish Plugins directory for Qt6 Establish TLS plugins for Qt6 services Minor change for release channel network manager Let windows build in parallel cores Wrong symbols Qt6 patch up for signal add missing qt6 package on deb builds boolean expressions are hard negative indexes should go to the end Intentionally fail cache move size checks to individual zone types Hardcode libs needed for building on Windows, as the regex was annoying Update wording use the --parallel option in all builds clean up the .ci scripts some more tweak fedora build add os parameter to compile.sh I don't really like this but it seems the easiest way I'd prefer if these types of quirks would live in the main configuration file, the yml fixup yml readd appended cache key to vcpkg step fix windows 32 quirk the json hash is already added to the key as well remove os parameter and clean up ci files set name_build.sh to output relative paths set backwards compatible version of xcode and qt on mac set QTDIR for mac builds on qt5 has no effect for qt6 export BUILD_DIR to name_build.sh merge mac build steps merge homebrew steps, set package suffix link qt5 remove brew link set qtdir to qt5 only compile.sh vars need to be empty not 0 fix sets manager search bar on qt 5.12/15 fix oracle subprocess errors being ignored on qt 5 clean up translation loading move en@source translation file so it will not get included in packages NOTE: this needs to be done at transifex as well! Use generator platform over osname Short circuit if not Win defined
135 lines
5.8 KiB
C++
135 lines
5.8 KiB
C++
#include "rng_sfmt.h"
|
|
|
|
#include <QDateTime>
|
|
#include <algorithm>
|
|
#include <climits>
|
|
#include <stdexcept>
|
|
|
|
// This is from gcc sources, namely from fixincludes/inclhack.def
|
|
// On C++11 systems, <cstdint> could be included instead.
|
|
#ifndef UINT64_MAX
|
|
#define UINT64_MAX (~(uint64_t)0)
|
|
#endif
|
|
|
|
RNG_SFMT::RNG_SFMT(QObject *parent) : RNG_Abstract(parent)
|
|
{
|
|
// initialize the random number generator with a 32bit integer seed (timestamp)
|
|
sfmt_init_gen_rand(&sfmt, QDateTime::currentDateTime().toSecsSinceEpoch());
|
|
}
|
|
|
|
/**
|
|
* This method is the rand() equivalent which calls the cdf with proper bounds.
|
|
*
|
|
* It is possible to generate random numbers from [-min, +/-max] though the RNG uses
|
|
* unsigned numbers only, so this wrapper handles some special cases for min and max.
|
|
*
|
|
* It is only necessary that the upper bound is larger or equal to the lower bound - with the exception
|
|
* that someone wants something like rand() % -foo.
|
|
*/
|
|
unsigned int RNG_SFMT::rand(int min, int max)
|
|
{
|
|
/* If min is negative, it would be possible to calculate
|
|
* cdf(0, max - min) + min
|
|
* There has been no use for negative random numbers with rand() though, so it's treated as error.
|
|
*/
|
|
if (min < 0) {
|
|
throw std::invalid_argument(
|
|
QString("Invalid bounds for RNG: Got min " + QString::number(min) + " < 0!\n").toStdString());
|
|
// at this point, the method exits. No return value is needed, because
|
|
// basically the exception itself is returned.
|
|
}
|
|
|
|
// For complete fairness and equal timing, this should be a roll, but let's skip it anyway
|
|
if (min == max)
|
|
return max;
|
|
|
|
// This is actually not used in Cockatrice:
|
|
// Someone wants rand() % -foo, so we compute -rand(0, +foo)
|
|
// This is the only time where min > max is (sort of) legal.
|
|
// Not handling this will cause the application to crash.
|
|
if (min == 0 && max < 0) {
|
|
return -cdf(0, -max);
|
|
}
|
|
|
|
// No special cases are left, except !(min > max) which is caught in the cdf itself.
|
|
return cdf(min, max);
|
|
}
|
|
|
|
/**
|
|
* Much thought went into this, please read this comment before you modify the code.
|
|
* Let SFMT() be an alias for sfmt_genrand_uint64() aka SFMT's rand() function.
|
|
*
|
|
* SMFT() returns a uniformly distributed pseudorandom number from 0 to UINT64_MAX.
|
|
* As SFMT() operates on a limited integer range, it is a _discrete_ function.
|
|
*
|
|
* We want a random number from a given interval [min, max] though, so we need to
|
|
* implement the (discrete) cumulative distribution function SFMT(min, max), which
|
|
* returns a random number X from [min, max].
|
|
*
|
|
* This CDF is by formal definition:
|
|
* SFMT(X; min, max) = (floor(X) - min + 1) / (max - min + 1)
|
|
*
|
|
* To get out the random variable, solve for X:
|
|
* floor(X) = SFMT(X; min, max) * (max - min + 1) + min - 1
|
|
* So this is, what rand(min, max) should look like.
|
|
* Problem: SFMT(X; min, max) * (max - min + 1) could produce an integer overflow,
|
|
* so it is not safe.
|
|
*
|
|
* One solution is to divide the universe into buckets of equal size depending on the
|
|
* range [min, max] and assign X to the bucket that contains the number generated
|
|
* by SFMT(). This equals to modulo computation and is not satisfying:
|
|
* If the buckets don't divide the universe equally, because the bucket size is not
|
|
* a divisor of 2, there will be a range in the universe that is biased because one
|
|
* bucket is too small thus will be chosen less equally!
|
|
*
|
|
* This is solved by rejection sampling:
|
|
* As SFMT() is assumed to be unbiased, we are allowed to ignore those random numbers
|
|
* from SFMT() that would force us to have an unequal bucket and generate new random
|
|
* numbers until one number fits into one of the other buckets.
|
|
* This can be compared to an ideal six sided die that is rolled until only sides
|
|
* 1-5 show up, while 6 represents something that you don't want. So you basically roll
|
|
* a five sided die.
|
|
*
|
|
* Note: If you replace the SFMT RNG with some other rand() function in the future,
|
|
* then you _need_ to change the UINT64_MAX constant to the largest possible random
|
|
* number which can be created by the new rand() function. This value is often defined
|
|
* in a RAND_MAX constant.
|
|
* Otherwise you will probably skew the outcome of the rand() method or worsen the
|
|
* performance of the application.
|
|
*/
|
|
unsigned int RNG_SFMT::cdf(unsigned int min, unsigned int max)
|
|
{
|
|
// This all makes no sense if min > max, which should never happen.
|
|
if (min > max) {
|
|
throw std::invalid_argument(QString("Invalid bounds for RNG: min > max! Values were: min = " +
|
|
QString::number(min) + ", max = " + QString::number(max))
|
|
.toStdString());
|
|
// at this point, the method exits. No return value is needed, because
|
|
// basically the exception itself is returned.
|
|
}
|
|
|
|
// First compute the diameter (aka size, length) of the [min, max] interval
|
|
const unsigned int diameter = max - min + 1;
|
|
|
|
// Compute how many buckets (each in size of the diameter) will fit into the
|
|
// universe.
|
|
// If the division has a remainder, the result is floored automatically.
|
|
const uint64_t buckets = UINT64_MAX / diameter;
|
|
|
|
// Compute the last valid random number. All numbers beyond have to be ignored.
|
|
// If there was no remainder in the previous step, limit is equal to UINT64_MAX.
|
|
const uint64_t limit = diameter * buckets;
|
|
|
|
uint64_t rand;
|
|
// To make the random number generation thread-safe, a mutex is created around
|
|
// the generation. Outside of the loop of course, to avoid lock/unlock overhead.
|
|
mutex.lock();
|
|
do {
|
|
rand = sfmt_genrand_uint64(&sfmt);
|
|
} while (rand >= limit);
|
|
mutex.unlock();
|
|
|
|
// Now determine the bucket containing the SFMT() random number and after adding
|
|
// the lower bound, a random number from [min, max] can be returned.
|
|
return (unsigned int)(rand / buckets + min);
|
|
}
|